From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 64FFA469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  4 Mar 2020 01:39:48 +0300 (MSK)
Date: Wed, 4 Mar 2020 01:39:45 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200303223945.rsj6vm3h5asf63xn@tkn_work_nb>
References: <cover.1580917791.git.imun@tarantool.org>
 <20200226224509.wunwgszrilnnmykf@tkn_work_nb>
 <20200227104840.GO404@tarantool.org>
 <20200227113535.kbkqmbxikllvk2bz@tkn_work_nb>
 <20200303161712.GY404@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200303161712.GY404@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb
	extension for LuaJIT
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

I don't think that it worth to do in-depth review from my side. But I
tried the extension, it works and gives output that I can interpret. It
also has the documentation that is available using gdb's built-in help
command. It is nice, thanks, Igor!

So the patchset LGTM. CCed Kirill.

Igor, please, file an issue for the further activity: we should ship the
tool in our packages (possibly tarantool-dev/devel) in paths, where gdb
will able to catch it automatically.

WBR, Alexander Turenko.

On Tue, Mar 03, 2020 at 07:17:12PM +0300, Igor Munkin wrote:
> Sasha,
> 
> I squashed the first patch of the series (gdb: introduce luajit-gdb
> extension) with the third one (gdb: enhance the extension loading) as
> you proposed supra.
> 
> As discussed offline, the second patch is left to separate the changes
> required for compatibility with Python 2 in git repo history.
> 
> Rebased, force-pushed to the branch.
> 
> On 27.02.20, Alexander Turenko wrote:
> > > * the feature port to Python 2 (I hope it can be dropped in some
> > > time)
> > 
> > According to [1] not before June, 2024. However I guess that in fact
> > it may be needed even after 2024.
> > 
> > Not soon.
> > 
> > [1]: https://wiki.centos.org/About/Product
> 
> -- 
> Best regards,
> IM