From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 50513469719 for ; Tue, 3 Mar 2020 11:25:45 +0300 (MSK) Date: Tue, 3 Mar 2020 11:25:43 +0300 From: Kirill Yukhin Message-ID: <20200303082543.cxzoeyriccwi6q35@tarantool.org> References: <20200228170130.81713-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200228170130.81713-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] replication: fix rebootstrap in case the instance is listed in box.cfg.replication List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 28 фев 20:01, Serge Petrenko wrote: > When checking wheter rejoin is needed, replica loops through all the > instances in box.cfg.replication, which makes it believe that there is a > master holding files, needed by it, since it accounts itself just like > all other instances. > So make replica skip itself when finding an instance which holds files > needed by it, and determining whether rebootstrap is needed. > > We already have a working test for the issue, it missed the issue due to > replica.lua replication settings. Fix replica.lua to optionally include > itself in box.cfg.replication, so that the corresponding test works > correctly. > > Closes #4759 > --- > https://github.com/tarantool/tarantool/issues/4759 > https://github.com/tarantool/tarantool/tree/sp/gh-4759-rebootstrap-fix THe patch LGTM. I've checked it into 2.2, 2.3 and master. -- Regards, Kirill Yukhin