From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9A22469719 for ; Mon, 2 Mar 2020 23:13:17 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id d27so592724lfq.12 for ; Mon, 02 Mar 2020 12:13:17 -0800 (PST) From: Cyrill Gorcunov Date: Mon, 2 Mar 2020 23:12:24 +0300 Message-Id: <20200302201227.31785-5-gorcunov@gmail.com> In-Reply-To: <20200302201227.31785-1-gorcunov@gmail.com> References: <20200302201227.31785-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 4/7] popen: log errors if popen creation failed List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml On error path we arm diag with error but strictly speaking some users (such as unit tests) do not have to access diag for logging. Thus log it explicitly for debug sake. Signed-off-by: Cyrill Gorcunov --- src/lib/core/popen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/core/popen.c b/src/lib/core/popen.c index ce7d7fff7..806d004bf 100644 --- a/src/lib/core/popen.c +++ b/src/lib/core/popen.c @@ -948,6 +948,7 @@ popen_new(struct popen_opts *opts) return handle; out_err: + diag_log(); saved_errno = errno; popen_delete(handle); for (i = 0; i < lengthof(pfd); i++) { -- 2.20.1