From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5E585469719 for ; Mon, 2 Mar 2020 23:12:32 +0300 (MSK) Received: by mail-lf1-f68.google.com with SMTP id n30so631200lfh.6 for ; Mon, 02 Mar 2020 12:12:32 -0800 (PST) From: Cyrill Gorcunov Date: Mon, 2 Mar 2020 23:12:20 +0300 Message-Id: <20200302201227.31785-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml Here are a few fixes for popen engine I discovered during testing on macos. Now the unit test passes. branch gorcunov/gh-4031-popen-fixup Cyrill Gorcunov (7): core/say: Export logger fd popen: allow accessing environ variable popen: close_inherited_fds - add support for macos/freebsd popen: log errors if popen creation failed popen: add logging in child process popen: handle setsid os specifics test/unit: add popen test src/lib/core/popen.c | 92 ++++++++------ src/lib/core/say.c | 6 + src/lib/core/say.h | 7 ++ test/unit/CMakeLists.txt | 3 + test/unit/popen.c | 250 +++++++++++++++++++++++++++++++++++++++ test/unit/popen.result | 25 ++++ 6 files changed, 348 insertions(+), 35 deletions(-) create mode 100644 test/unit/popen.c create mode 100644 test/unit/popen.result base-commit: 5e5d5a4a7a567891de2082e7f6c173497bb4e84b -- 2.20.1