From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 531D8469719 for ; Mon, 2 Mar 2020 13:59:58 +0300 (MSK) Date: Mon, 2 Mar 2020 13:59:55 +0300 From: Nikita Pettik Message-ID: <20200302105955.GA43956@tarantool.org> References: <20200226161308.73170-1-k.sosnin@tarantool.org> <83fa4b26-3f6d-ce5c-56eb-4c2034004576@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <83fa4b26-3f6d-ce5c-56eb-4c2034004576@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sequence: return correct error on using dropped sequence List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 29 Feb 16:43, Vladislav Shpilevoy wrote: > LGTM. > > On 26/02/2020 17:13, Chris Sosnin wrote: > > This code is called from C, so it shouldn't throw. > > > > Closes #4753 > > --- > > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4753-sequence-cpp-exception > > issue: https://github.com/tarantool/tarantool/issues/4753 > > Patch LGTM as well, but I see that 3 out of 4 runs on travis result in fail: https://travis-ci.org/tarantool/tarantool/builds/655369924?utm_source=github_status&utm_medium=notification Are these known failures (box/access etc)?