From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D42B6469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  1 Mar 2020 17:27:01 +0300 (MSK)
Date: Sun, 1 Mar 2020 17:21:39 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200301142139.GU404@tarantool.org>
References: <cover.1581790002.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1581790002.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] box.tuple.* cleanup
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: babinoleg@mail.ru, tarantool-patches@dev.tarantool.org

Vlad,

Thanks for the patch, LGTM.

On 15.02.20, Vladislav Shpilevoy wrote:
> The patchset removes or documents some internal functions in
> box.tuple.* namespace: box.tuple.bless()/encode()/is().
> 
> Bless() and encode() were moved to a more secret place, where
> suicidal users can't find it.
> 
> Is() is documented, because it is actually a useful thing.
> 
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4662-fiber-storage-leak
> Issue: https://github.com/tarantool/tarantool/issues/4662
> 
> Vladislav Shpilevoy (2):
>   tuple: hide internal functions from box.tuple.*
>   tuple: make box.tuple.is() public
> 
>  src/box/lua/schema.lua  |  4 ++--
>  src/box/lua/tuple.lua   | 15 +++++++++++++--
>  test/box/tuple.result   | 40 ++++++++++++++++++++++++++++++++++++++++
>  test/box/tuple.test.lua | 14 ++++++++++++++
>  4 files changed, 69 insertions(+), 4 deletions(-)
> 
> -- 
> 2.21.1 (Apple Git-122.3)
> 

-- 
Best regards,
IM