From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DFC62469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 28 Feb 2020 21:42:36 +0300 (MSK)
Date: Fri, 28 Feb 2020 21:37:16 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200228183716.GS404@tarantool.org>
References: <cover.1582810913.git.avtikhon@tarantool.org>
 <c4fb80ed8bbaa8f3f413636acb07d3aa8c6ec034.1582810913.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <c4fb80ed8bbaa8f3f413636acb07d3aa8c6ec034.1582810913.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] test: rename test files
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

Sasha,

Thanks for the patch. I left some comments below, please consider them.

On 27.02.20, Alexander V. Tikhonov wrote:
> Renamed test files in the following way:
> <repo>-<number>-<comment>.test.lua
> where "external repo" is github repository:

Typo: s/external repo/<repo>/.

>   gh - tarantool/tarantool
>   lj - luajit/luajit

Typo: s/luajit/LuaJIT/g.

>   or - openresty/lua-resty-core

Typo: s/lua-resty-core/luajit2/.

> 
> Close #4655
> ---
>  test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua}    | 0
>  ...ording.test.lua => gh-4476-fix-string-find-recording.test.lua} | 0
>  ...mm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} | 0
>  ...JIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} | 0
>  ...LuaJIT_505.test.lua => lj-505-fold-icorrect-behavior.test.lua} | 0
>  test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua}  | 0
>  ...LuaJIT_524.test.lua => or-524-fold-icorrect-behavior.test.lua} | 0
>  7 files changed, 0 insertions(+), 0 deletions(-)
>  rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (100%)
>  rename test/{fix_string_find_recording.test.lua => gh-4476-fix-string-find-recording.test.lua} (100%)
>  rename test/{pairsmm_tarantool_4560.test.lua => gh-4560-pairsmm-is-set.test.lua} (100%)
>  rename test/{table_chain_bug_LuaJIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} (100%)
>  rename test/{fold_bug_LuaJIT_505.test.lua => lj-505-fold-icorrect-behavior.test.lua} (100%)
>  rename test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} (100%)
>  rename test/{fold_bug_LuaJIT_524.test.lua => or-524-fold-icorrect-behavior.test.lua} (100%)
> 
> diff --git a/test/gh.test.lua b/test/gh-3196-incorrect-string-length.test.lua
> similarity index 100%
> rename from test/gh.test.lua
> rename to test/gh-3196-incorrect-string-length.test.lua
> diff --git a/test/fix_string_find_recording.test.lua b/test/gh-4476-fix-string-find-recording.test.lua
> similarity index 100%
> rename from test/fix_string_find_recording.test.lua
> rename to test/gh-4476-fix-string-find-recording.test.lua

I propose test/gh-4476-fix-string-find-recording.test.lua.

> diff --git a/test/pairsmm_tarantool_4560.test.lua b/test/gh-4560-pairsmm-is-set.test.lua
> similarity index 100%
> rename from test/pairsmm_tarantool_4560.test.lua
> rename to test/gh-4560-pairsmm-is-set.test.lua

Please rebase your changes on the stable branch, since this test has
been removed in a9eebfa.

> diff --git a/test/table_chain_bug_LuaJIT_494.test.lua b/test/lj-494-table-chain-infinite-loop.test.lua
> similarity index 100%
> rename from test/table_chain_bug_LuaJIT_494.test.lua
> rename to test/lj-494-table-chain-infinite-loop.test.lua
> diff --git a/test/fold_bug_LuaJIT_505.test.lua b/test/lj-505-fold-icorrect-behavior.test.lua
> similarity index 100%
> rename from test/fold_bug_LuaJIT_505.test.lua
> rename to test/lj-505-fold-icorrect-behavior.test.lua

I propose test/lj-505-fold-no-strref-for-ptrdiff.test.lua.

> diff --git a/test/unsink_64_kptr.test.lua b/test/or-232-unsink-64-kptr.test.lua
> similarity index 100%
> rename from test/unsink_64_kptr.test.lua
> rename to test/or-232-unsink-64-kptr.test.lua
> diff --git a/test/fold_bug_LuaJIT_524.test.lua b/test/or-524-fold-icorrect-behavior.test.lua
> similarity index 100%
> rename from test/fold_bug_LuaJIT_524.test.lua
> rename to test/or-524-fold-icorrect-behavior.test.lua

The original issue comes from LuaJIT/LuaJIT queue, so the prefix should
be 'lj-' instead of 'or-'. Also there is a typo: s/icorrect/incorrect/.

I propose test/lj-524-fold-conv-respect-src-irt.test.lua.

> -- 
> 2.17.1
> 

-- 
Best regards,
IM