From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp10.mail.ru (smtp10.mail.ru [94.100.181.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 61A42469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 28 Feb 2020 14:55:49 +0300 (MSK)
Date: Fri, 28 Feb 2020 14:55:44 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200228115544.2yt4yx6vlon5qomi@tkn_work_nb>
References: <20200228094815.13826-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200228094815.13826-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 0/2] popen: fixes to make master
	branch happy
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Due to -Werror error on the test reverted its disabling and reverted the
test itself.

WBR, Alexander Turenko.

On Fri, Feb 28, 2020 at 12:48:13PM +0300, Cyrill Gorcunov wrote:
> The rule of thumb is to keep master branch in good shape so that
> it will be used to verify own work on top. The popen test cause
> some problems which I have to rework thus just revert it.
> 
> Also fix popen build on non linux machines.
> 
> branch gorcunov/gh-4031-popen-fixes-2
> 
> Cyrill Gorcunov (2):
>   popen: fix empty envp type for nonlinux builds
>   Revert "test: unit/popen"
> 
>  src/lib/core/popen.c     |   2 +-
>  test/unit/CMakeLists.txt |   3 -
>  test/unit/popen.c        | 253 ---------------------------------------
>  test/unit/popen.result   |  28 -----
>  4 files changed, 1 insertion(+), 285 deletions(-)
>  delete mode 100644 test/unit/popen.c
>  delete mode 100644 test/unit/popen.result
> 
> 
> base-commit: 40a516477aa337b3d15184f99bb1ec1a3095d60a
> -- 
> 2.20.1
>