From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F15E8469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 27 Feb 2020 23:27:16 +0300 (MSK)
Date: Thu, 27 Feb 2020 23:27:16 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200227202716.n4x42aq5ixsinscd@tarantool.org>
References: <20200227141628.13782-1-gorcunov@gmail.com>
 <20200227141628.13782-4-gorcunov@gmail.com>
 <20200227194729.jposbdcfrskvtqz2@tarantool.org>
 <20200227202031.GG2464@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200227202031.GG2464@uranus>
Subject: Re: [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage
 right before journal_write
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On 27 фев 23:20, Cyrill Gorcunov wrote:
> On Thu, Feb 27, 2020 at 10:47:29PM +0300, Kirill Yukhin wrote:
> > Hello,
> > 
> > // This is not an official review. Just a nitpicking.
> > 
> > > +space:insert{1}
> > > +---
> > > +- error: Failed to allocate 0 bytes in region for journal_entry
> > 
> > Why 0? How could we ever fail to allocate 0 bytes?
> 
> To make this message immutable even if size of the journal_entry
> structure get changed. We don't care about the size here but rather
> the fact that allocation failed. If you prefer I can put some
> randomn number here instead.

Now I get it. Sure, let's make it 0 (zero).

--
Regards, Kirill Yukhin