From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 92F21469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 27 Feb 2020 23:20:34 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id d10so668018ljl.9
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 27 Feb 2020 12:20:34 -0800 (PST)
Date: Thu, 27 Feb 2020 23:20:31 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200227202031.GG2464@uranus>
References: <20200227141628.13782-1-gorcunov@gmail.com>
 <20200227141628.13782-4-gorcunov@gmail.com>
 <20200227194729.jposbdcfrskvtqz2@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200227194729.jposbdcfrskvtqz2@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage
 right before journal_write
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Feb 27, 2020 at 10:47:29PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> // This is not an official review. Just a nitpicking.
> 
> > +space:insert{1}
> > +---
> > +- error: Failed to allocate 0 bytes in region for journal_entry
> 
> Why 0? How could we ever fail to allocate 0 bytes?

To make this message immutable even if size of the journal_entry
structure get changed. We don't care about the size here but rather
the fact that allocation failed. If you prefer I can put some
randomn number here instead.