From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C673D469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 27 Feb 2020 22:47:30 +0300 (MSK)
Date: Thu, 27 Feb 2020 22:47:29 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200227194729.jposbdcfrskvtqz2@tarantool.org>
References: <20200227141628.13782-1-gorcunov@gmail.com>
 <20200227141628.13782-4-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200227141628.13782-4-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 3/3] box/txn: clear fiber storage
 right before journal_write
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

// This is not an official review. Just a nitpicking.

On 27 фев 17:16, Cyrill Gorcunov wrote:
> --- a/test/box/errinj.result
> +++ b/test/box/errinj.result
> @@ -134,6 +135,25 @@ errinj.set("ERRINJ_TESTING", false)
>  ---
>  - ok
>  ...
> +-- Check journal entries allocation failure
> +errinj.set("ERRINJ_JOURNAL_NEW", true)
> +---
> +- ok
> +...
> +space:insert{1}
> +---
> +- error: Failed to allocate 0 bytes in region for journal_entry

Why 0? How could we ever fail to allocate 0 bytes?

--
Regards, Kirill Yukhin