From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3F78A469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 27 Feb 2020 17:35:29 +0300 (MSK)
Date: Thu, 27 Feb 2020 17:30:08 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200227143008.GP404@tarantool.org>
References: <1582130122.751366742@f143.i.mail.ru>
 <20200225222015.wt5azo2dlexkd745@tarantool.org>
 <1582726860.445056855@f382.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1582726860.445056855@f382.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH] box: user.grant error should be
 versatile
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches <tarantool-patches@dev.tarantool.org>

Masha,

Thanks, the patch LGTM, but I left a few nits below.

On 26.02.20, Maria Khaydich wrote:
> 
> Looks like this patch caused some tests to fail according to Sasha (avtikhon).
> I made another commit fixing the issue.
>  
> ----------------------------------------------------------------------
> Previous commit that was merged into master did not do
> proper clean-up. That caused occasional failures of other
> tests, all with the same error saying user 'guest' already
> had access on universe.

I propose the following rewording for the commit message:
| box: use non-default user for tests
|
| The commit e8009f4158fc2d6efa2824cd634564b3c7a2f899
| ('box: user.grant error should be versatile') introduced a flaky test,
| since it provides a non-default grants for the default 'guest' user
| and doesn't drop the changes at the end.
| To avoid flaky failures a new user is created for the test and dropped
| when the related tests are finished.
Feel free to change it on your own.

>  
> Closes #714

I guess Follow-up #714 is more appropriate here.

> ---
> Branch:
> https://github.com/tarantool/tarantool/compare/eljashm/gh-714-box-schema-user-grant-invalid-error  
> 
>  test/box/access.result   | 18 ++++++++++++------
>  test/box/access.test.lua | 10 ++++++----
>  2 files changed, 18 insertions(+), 10 deletions(-)

<snipped>

>  
> --
> Maria Khaydich
>  
>  

-- 
Best regards,
IM