From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AA9CF469719 for ; Thu, 27 Feb 2020 17:17:05 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id q8so3630498ljb.2 for ; Thu, 27 Feb 2020 06:17:05 -0800 (PST) From: Cyrill Gorcunov Date: Thu, 27 Feb 2020 17:16:27 +0300 Message-Id: <20200227141628.13782-3-gorcunov@gmail.com> In-Reply-To: <20200227141628.13782-1-gorcunov@gmail.com> References: <20200227141628.13782-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 2/3] box/txn: log error explicitly in txn_commit List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml To be on same way as we do in txn_write_to_wal. Signed-off-by: Cyrill Gorcunov --- src/box/txn.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/box/txn.c b/src/box/txn.c index cac97d1eb..9e2888c09 100644 --- a/src/box/txn.c +++ b/src/box/txn.c @@ -604,8 +604,10 @@ txn_commit(struct txn *txn) fiber_set_cancellable(cancellable); } int res = txn->signature >= 0 ? 0 : -1; - if (res != 0) + if (res != 0) { diag_set(ClientError, ER_WAL_IO); + diag_log(); + } /* Synchronous transactions are freed by the calling fiber. */ txn_free(txn); -- 2.20.1