From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E31FA469719 for ; Thu, 27 Feb 2020 13:54:01 +0300 (MSK) Date: Thu, 27 Feb 2020 13:48:40 +0300 From: Igor Munkin Message-ID: <20200227104840.GO404@tarantool.org> References: <20200226224509.wunwgszrilnnmykf@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200226224509.wunwgszrilnnmykf@tkn_work_nb> Subject: Re: [Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb extension for LuaJIT List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org Sasha, On 27.02.20, Alexander Turenko wrote: > Are not it worth to squash those commits? Now the series looks as > 'feature + fixup + fixup' and since we don't pushed it yet to a I see it for now as: * the feature * the feature port to Python 2 (I hope it can be dropped in some time) * several enhancments asked by Sergos (yep, it can be squashed prior to be pushed to the long-term branch) > long-term branch is looks okay to squash fixups into the first commit. > > It is up to you, I just asked. I'll think about it, thanks. > > WBR, Alexander Turenko. -- Best regards, IM