From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7FEB0469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 26 Feb 2020 02:30:57 +0300 (MSK)
Date: Wed, 26 Feb 2020 02:30:55 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200225233055.GB12687@tarantool.org>
References: <1581359737.397395198@f221.i.mail.ru>
 <20200225222609.ve6gnec6wirieobk@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200225222609.ve6gnec6wirieobk@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] box: sql prepare and execute
 statistics should be reflected in box.stat()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches <tarantool-patches@dev.tarantool.org>

On 26 Feb 01:26, Kirill Yukhin wrote:
> Hello,
> 
> On 10 фев 21:35, Maria Khaydich wrote:
> > 
> > Calling prepare and execute did not update corresponding request statistics
> > in the box.stat table. This happened because methods that collect stats were
> > never called where they should have been.
> >  
> > Closes #4756
> > 
> > ---
> > Issue:
> > https://github.com/tarantool/tarantool/issues/4756
> > Branch:
> > https://github.com/tarantool/tarantool/compare/eljashm/gh-4756-box-stat-execute-and-prepare-not-updated
> 
> I've checked your patch into 2.3 and master.

Kirill, it also should be backported to 2.2 skipping part related to
'prepare' feature.
 
> --
> Regards, Kirill Yukhin