From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D1326469719 for ; Mon, 24 Feb 2020 21:18:57 +0300 (MSK) Date: Mon, 24 Feb 2020 21:18:57 +0300 From: Kirill Yukhin Message-ID: <20200224181857.3p5leezuuedt3ucx@tarantool.org> References: <20200221123203.6956-1-k.sosnin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200221123203.6956-1-k.sosnin@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] app: verify unix socket path length in socket.tcp_server() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 21 фев 15:32, Chris Sosnin wrote: > Providing socket pathname longer than UNIX_PATH_MAX to socket.tcp_server() > will not cause any error, lbox_socket_local_resolve will just truncate the > name according to the limit, causing bad behavior (tarantool will try to > access a socket, which doesn't exist). Thus, let's verify, that pathname > can fit into buffer. > > Closes #4634 > --- > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4634-verify-socket-path-length > issue: https://github.com/tarantool/tarantool/issues/4634 I've checked your patch into 2.3 and master. -- Regards, Kirill Yukhin