From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7217B469719 for ; Fri, 21 Feb 2020 18:42:45 +0300 (MSK) Date: Fri, 21 Feb 2020 18:42:44 +0300 From: Nikita Pettik Message-ID: <20200221154244.GE51816@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 3/3] upgrade: fix generated sequence upgrade from 2.1 List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 17 Feb 21:57, Vladislav Shpilevoy wrote: > The bug was in an attempt to update a record in _space_sequence > in-place, to add field path and number. This was not properly > supported by the system space's trigger, and was banned in the > previous patch of this series. > > But delete + tuple update + insert work fine. The patch uses them. > > To test it the old disabled and heavily outdated > xlog/upgrade.test.lua was replaced with a smaller analogue, which > is supposed to be created separately for each upgrade bug. > According to the new policy of creating test files. > > The patch tries to make it easy to add new upgrade tests and > snapshots. A new test should consist of fill.lua script to > populate spaces, snapshot, needed xlogs, and a .test.lua file. > Fill script and binaries should be in the same folder as test file > name, which is located in version folder. Like this: I'm okay with this approach but could you document it somewhere (e.g. on our wiki github page)? > xlog/ > | > + .test.lua > | > +- upgrade/ > | > +- / > | | > | +-/ > | | > | +- fill.lua > | +- *.snap > | +- *.xlog > > Version is supposed to say explicitly what a version files in > there have. Patch itself is LGTM.