From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D1F33469719 for ; Fri, 21 Feb 2020 14:19:14 +0300 (MSK) Date: Fri, 21 Feb 2020 14:19:35 +0300 From: Alexander Turenko Message-ID: <20200221111935.gw7rj7vlhc2jquam@tkn_work_nb> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v1] test: add more tests to packaging testing List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org I have several questions, see below. WBR, Alexander Turenko. On Mon, Dec 30, 2019 at 02:10:07PM +0300, Alexander V. Tikhonov wrote: > Changed number of tests to packaging testing jobs from > suites: "unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/", > to all suites except 'replication/' suite. Also added > testing to the all available packing jobs except 'CentOS 6'. > > Removed test-run option that run testing inline to be > able to run it in parallel. Also changed 'test-run' to > 'make test-force' command. > > Closes #4599 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4599-packages-testing-full-ci > Issue: https://github.com/tarantool/tarantool/issues/4599 > > rpm/tarantool.spec | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/rpm/tarantool.spec b/rpm/tarantool.spec > index ff95ed646..bc1fb5aff 100644 > --- a/rpm/tarantool.spec > +++ b/rpm/tarantool.spec > @@ -70,17 +70,18 @@ BuildRequires: libunwind-devel > %endif > > # For tests > -%if (0%{?fedora} >= 22 || 0%{?rhel} == 7) > -BuildRequires: python >= 2.7 > -BuildRequires: python-six >= 1.9.0 > -BuildRequires: python-gevent >= 1.0 > -BuildRequires: python-yaml >= 3.0.9 > -%endif > %if (0%{?fedora} >= 31 || 0%{?rhel} >= 8) > BuildRequires: python2 >= 2.7 > BuildRequires: python2-six >= 1.9.0 > BuildRequires: python2-gevent >= 1.0 > BuildRequires: python2-yaml >= 3.0.9 > +%else > +%if (0%{?rhel} != 6) Don't understood: what was actually changed? We have Fedora 28-31 and CentOS 6-8 in testing / deploying. > +BuildRequires: python >= 2.7 > +BuildRequires: python-six >= 1.9.0 > +BuildRequires: python-gevent >= 1.0 > +BuildRequires: python-yaml >= 3.0.9 > +%endif > %endif > > Name: tarantool > @@ -160,13 +161,13 @@ make %{?_smp_mflags} > rm -rf %{buildroot}%{_datarootdir}/doc/tarantool/ > > %check > -%if (0%{?fedora} >= 22 || 0%{?rhel} >= 7) > # https://github.com/tarantool/tarantool/issues/1227 > echo "self.skip = True" > ./test/app/socket.skipcond > # https://github.com/tarantool/tarantool/issues/1322 > echo "self.skip = True" > ./test/app/digest.skipcond Those two issues now closed. Maybe it is time to enable those tests? > # run a safe subset of the test suite I would file an issue re enabling replication test suite and mention it here: it looks as good process for me. However, up to you. > -cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/ > +%if (0%{?rhel} != 6) > + TEST_RUN_EXCLUDE='replication/' make test-force > %endif Flaky fails rate will increase on Travis-CI if we'll enable parallelization. Either discard this change or enable it only for gitlab-ci. Nit: Use whitespace (not tab) for indentation here.