From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp20.mail.ru (smtp20.mail.ru [94.100.179.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DFBE1469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 21 Feb 2020 14:00:59 +0300 (MSK)
Date: Fri, 21 Feb 2020 14:00:57 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20200221110057.GC68447@tarantool.org>
References: <20200122145159.15751-1-sergeiv@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200122145159.15751-1-sergeiv@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Increase limits for debug.traceback
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Voinov <sergeiv@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

Thanks for the patch!
Is there a way in cmake to document the newly introduced definitions?
At least, add comment why we have 2 traceback levels and their relevance
- should one be no less than the other? And what does IDSIZE regulate?

regards,
Sergos

On 22 янв 17:51, Sergey Voinov wrote:
> Currently debug.traceback cuts out path prefixes
> and removes intermediate frames. This makes it harder
> to debug and navigate to files right from terminal.
> 
> This change in main trunk adds default traceback
> limits as defines to cmake/luajit.cmake file.
> 
> Please see the commit for #4581 for luajit submodule.
> 
> Closes: #4581
> ---
>  issue: https://github.com/tarantool/tarantool/issues/4581
>  branch: https://github.com/tarantool/tarantool/tree/servoin/gh-4581-debug-limits_2
>  cmake/luajit.cmake | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake
> index 072db8269..373e88458 100644
> --- a/cmake/luajit.cmake
> +++ b/cmake/luajit.cmake
> @@ -282,6 +282,13 @@ macro(luajit_build)
>          DESTINATION ${MODULE_INCLUDEDIR})
>  endmacro()
>  
> +#
> +# Definitions for luajit debug traceback limits
> +#
> +add_definitions(-DLUA_TRACEBACK_LEVELS1=25)
> +add_definitions(-DLUA_TRACEBACK_LEVELS2=25)
> +add_definitions(-DLUA_IDSIZE=128)
> +
>  #
>  # Building shipped luajit only if there is no
>  # usable system one (see cmake/luajit.cmake) or by demand.
> -- 
> 2.17.1
>