From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BC760469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Feb 2020 17:34:59 +0300 (MSK)
Date: Thu, 20 Feb 2020 17:34:58 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200220143458.GC95807@tarantool.org>
References: <20200219183713.17646-1-gorcunov@gmail.com>
 <20200219183713.17646-2-gorcunov@gmail.com>
 <20200220141048.GG40100@tarantool.org>
 <20200220141610.GF2788@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200220141610.GF2788@uranus>
Subject: Re: [Tarantool-patches] [PATCH 01/14] box/txn: fix void args mess
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On 20 Feb 17:16, Cyrill Gorcunov wrote:
> On Thu, Feb 20, 2020 at 05:10:48PM +0300, Nikita Pettik wrote:
> > On 19 Feb 21:37, Cyrill Gorcunov wrote:
> > > Using void explicitly in functions which take
> > > no arguments allows to optimize code a bit and
> > > don't assume if there might be variable args.
> > > 
> > > Moreover in commit e070cc4d9 we dropped arguments
> > > from txn_begin but didn't update vy_scheduler.c.
> > > The compiler didn't complain because it assumed
> > > there are vargs.
> > > 
> > > Acked-by: Konstantin Osipov <kostja.osipov@gmail.com>
> > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > 
> > LGTM. I assume you can push such patches aimed solely at refactoring
> > (taking into account second ack).
> 
> Thanks, the first 4 patches are just namings and ect, no
> functional changes. Actually I've prepared the branch
> for this and gave it to Kirill. Letme talk to him,
> I think I'll push myself and add your Acks as well.

Pushed to master (first 4 patches).