From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 014FD469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Feb 2020 17:15:01 +0300 (MSK)
Date: Thu, 20 Feb 2020 17:15:01 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200220141501.GA95807@tarantool.org>
References: <20200219183713.17646-1-gorcunov@gmail.com>
 <20200219183713.17646-4-gorcunov@gmail.com>
 <20200220141252.GI40100@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200220141252.GI40100@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 03/14] box/journal: sanitize
 completion naming
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On 20 Feb 17:12, Nikita Pettik wrote:
> On 19 Feb 21:37, Cyrill Gorcunov wrote:
> > Instead of on_done use on_complete prefix
> > since done it too general while we're trying
> > to complete write procedue. Also it is more
> > consistent with txn_complete name.
> > 
> > Acked-by: Konstantin Osipov <kostja.osipov@gmail.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> >  src/box/journal.c |  8 ++++----
> >  src/box/journal.h | 12 ++++++------
> >  2 files changed, 10 insertions(+), 10 deletions(-)
> >
> 
> LGTM
> 
> Btw why not to do the same with txn_entry_done_cb ?
>

Nevermind, it is done in the next patch (I've accidentally skipped it).