From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D7FC1469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Feb 2020 16:27:29 +0300 (MSK)
Date: Thu, 20 Feb 2020 16:27:27 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200220132727.GF40100@tarantool.org>
References: <cover.1580856721.git.v.shpilevoy@tarantool.org>
 <20200220061505.kzbzgcgyjx6b4nkp@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200220061505.kzbzgcgyjx6b4nkp@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Don't truncate float in
	update
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On 20 Feb 09:15, Kirill Yukhin wrote:
> Hello,
> 
> On 04 фев 23:53, Vladislav Shpilevoy wrote:
> > The patchset fixes float value truncation in
> > tuple/space:update/upsert. First commit fixes the actual issue,
> > but introduces another bug that a float value can be stored into a
> > field having double type in its format.
> > 
> > The rest 3 commits fix this new bug.
> > 
> > However, there is an alternative how these 3 could be done. My
> > solution is that I calculate the result types in
> > xrow_update_*_store() functions. Because of that I don't know the
> > types during xrow_update_*_sizeof(), and it needs to return the
> > maximal possible size instead of exact size. The alternative is to
> > calculate types during sizeof. It would allow to return the exact
> > size. But it also would complicate the code. I can implement this
> > option if it looks better.
> > 
> > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4701-update-float-truncate
> > Issue: https://github.com/tarantool/tarantool/issues/4701
> 
> LGTM. I've checked your patchset into 2.3 and master.

It seems you forgot to update changelog. Vlad, could you please
paste it here https://github.com/tarantool/tarantool/releases/tag/untagged-2929e826f0a4c08b1c81
 
> --
> Regards, Kirill Yukhin