From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 43E0C469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Feb 2020 14:17:57 +0300 (MSK)
Date: Thu, 20 Feb 2020 14:12:37 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200220111237.GD404@tarantool.org>
References: <cover.1581625524.git.babinoleg@mail.ru>
 <be90bf2be31fbe4be09dccf1662d3d988416fccf.1581625524.git.babinoleg@mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <be90bf2be31fbe4be09dccf1662d3d988416fccf.1581625524.git.babinoleg@mail.ru>
Subject: Re: [Tarantool-patches] [PATCH 1/3] lua: fix incorrect
 table.deepcopy __metatable handling
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: olegrok@tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Oleg,

Thanks for the patch. I totally agree with Vlad regarding the debug.*
usage and porting table.deepcopy to C. Propose also to discard this
patch.

On 13.02.20, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> Before this patch we got metatabe of original table
> using "getmetatable" function. It leads to the error
> if original table contained __metatable that could be
> e.g. a string or a number.
> To fix this problem getmetatable was replaced to debug.getmetatable.
> 
> Closes #4340
> ---
> Issue: https://github.com/tarantool/tarantool/issues/4340
>  src/lua/table.lua           |  2 +-
>  test/app-tap/table.test.lua | 20 +++++++++++++++++++-
>  2 files changed, 20 insertions(+), 2 deletions(-)
> 

<snipped>

> -- 
> 2.23.0
> 

-- 
Best regards,
IM