From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 548B3469719 for ; Thu, 20 Feb 2020 14:05:46 +0300 (MSK) Date: Thu, 20 Feb 2020 14:00:26 +0300 From: Igor Munkin Message-ID: <20200220110026.GC404@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 2/3] lua: table.deepcopy ignores __pairs metamethod List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: olegrok@tarantool.org Cc: Oleg Babin , tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Oleg, Thanks for the patch, but since we reverted the corresponding breakage[1] I guess the changes are irrelevant. Discarding it. On 13.02.20, olegrok@tarantool.org wrote: > From: Oleg Babin > > After 1d85144a9b4bbbb026402848efde1ab98bf72633 > table.deepcopy changed the behaviour and started > iterate through tables considering __pairs metamethod. > In some cases it broke backward compatibility. > To avoid such problem let's ignore __pairs > and iterate through tables as it was before > > Closes #4770 > Follow-up #4560 > --- > Issue: https://github.com/tarantool/tarantool/issues/4770 > Branch: https://github.com/tarantool/tarantool/tree/olegrok/table-fixes > src/lua/table.lua | 7 ++++++- > test/app-tap/table.test.lua | 26 +++++++++++++++++++++++++- > 2 files changed, 31 insertions(+), 2 deletions(-) > > -- > 2.23.0 > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-February/014304.html -- Best regards, IM