From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6E923469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 20 Feb 2020 14:02:23 +0300 (MSK)
Date: Thu, 20 Feb 2020 13:57:02 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200220105702.GB404@tarantool.org>
References: <cover.1581625524.git.babinoleg@mail.ru>
 <9330b681273b2789ff147d5769736406695ca23a.1581625524.git.babinoleg@mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <9330b681273b2789ff147d5769736406695ca23a.1581625524.git.babinoleg@mail.ru>
Subject: Re: [Tarantool-patches] [PATCH 3/3] tap: is_deeply ignores __pairs
	metamethod
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: olegrok@tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Oleg,

Thanks for the patch, but since we reverted the corresponding
breakage[1] I guess the changes are irrelevant. Discarding it.

On 13.02.20, olegrok@tarantool.org wrote:
> From: Oleg Babin <babinoleg@mail.ru>
> 
> After 1d85144a9b4bbbb026402848efde1ab98bf72633
> is_deeply could use __pairs metamethod when
> iterated through tables. It led to situation
> when two similar tables could be considered
> as different.
> To eliminate such situation default pairs
> was replaced with "pure" pairs that ignores
> __pairs metamethod
> 
> Follow-up #4770, #4560
> ---
>  src/lua/tap.lua           |  9 ++++++---
>  test/app-tap/tap.result   |  6 ++++--
>  test/app-tap/tap.test.lua | 24 +++++++++++++++++++++++-
>  3 files changed, 33 insertions(+), 6 deletions(-)
> 

<snipped>

> -- 
> 2.23.0
> 

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-February/014304.html

-- 
Best regards,
IM