From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CA4BA469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 19 Feb 2020 23:01:32 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id 9so1100934lfq.10
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 19 Feb 2020 12:01:32 -0800 (PST)
Date: Wed, 19 Feb 2020 23:01:29 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200219200129.GC2788@uranus>
References: <20200219183713.17646-1-gorcunov@gmail.com>
 <20200219183713.17646-15-gorcunov@gmail.com>
 <20200219190935.GA30094@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200219190935.GA30094@atlas>
Subject: Re: [Tarantool-patches] [PATCH 14/14] box/txn: use journal_write in
	txn_commit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Wed, Feb 19, 2020 at 10:09:35PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/02/19 21:44]:
> > This allows us to keep wait for transaction
> > complete in one place -- inside journal_write.
> > 
> 
> I thinks this patch set is on track. I would go further and would
> add patches which push journal_write() implementation down to
> wal.cc, since only wal.cc's journal_write is different from
> journal_write_async().

Thanks, will do.