From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 679B4469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 19 Feb 2020 22:09:38 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id e18so1495997ljn.12
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 19 Feb 2020 11:09:38 -0800 (PST)
Date: Wed, 19 Feb 2020 22:09:35 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200219190935.GA30094@atlas>
References: <20200219183713.17646-1-gorcunov@gmail.com>
 <20200219183713.17646-15-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200219183713.17646-15-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 14/14] box/txn: use journal_write in
	txn_commit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/02/19 21:44]:
> This allows us to keep wait for transaction
> complete in one place -- inside journal_write.
> 

I thinks this patch set is on track. I would go further and would
add patches which push journal_write() implementation down to
wal.cc, since only wal.cc's journal_write is different from
journal_write_async().


-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com