From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A0174469719 for ; Wed, 19 Feb 2020 17:53:07 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id z26so301470lfg.13 for ; Wed, 19 Feb 2020 06:53:07 -0800 (PST) Date: Wed, 19 Feb 2020 17:53:05 +0300 From: Cyrill Gorcunov Message-ID: <20200219145305.GB2788@uranus> References: <0eca2c9457d95dbef38556d738f1e5818468a175.1582119629.git.korablev@tarantool.org> <20200219142627.GA2788@uranus> <20200219143051.GA40100@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219143051.GA40100@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/7] box/error: introduce box.error.set() method List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On Wed, Feb 19, 2020 at 05:30:51PM +0300, Nikita Pettik wrote: > > > > diag_set_error already has assert(e != NULL), maybe we could omit this one? > > Yep, you are right, this assertion is likely to be redundant. Thanks, > will drop it while preparing next patch-set version. I think we could clean it on top later :)