From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 02AEF469719 for ; Wed, 19 Feb 2020 12:02:57 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id q8so26183145ljb.2 for ; Wed, 19 Feb 2020 01:02:57 -0800 (PST) Date: Wed, 19 Feb 2020 12:02:51 +0300 From: Konstantin Osipov Message-ID: <20200219090251.GC6538@atlas> References: <257cb279bd1b62ef6ff98aa4fa7226ba1bf3b2d0.1582046958.git.sergepetrenko@tarantool.org> <20200218190324.GB20569@atlas> <93920A98-9B17-43AB-86C2-494161FC032B@tarantool.org> <20200219085254.GB6538@atlas> <1C823375-D749-4A76-960D-2B45FD987A80@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1C823375-D749-4A76-960D-2B45FD987A80@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 2/4] recovery: allow to ignore rows coming from a certain instance List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Serge Petrenko [20/02/19 12:01]: > > > > > 19 февр. 2020 г., в 11:52, Konstantin Osipov написал(а): > > > > * Serge Petrenko [20/02/19 11:45]: > >>> This is a strange way to mute rows from self. Why not set vclock > >>> component to infinity as I suggested multiple times? Why not > >>> respond to me with objection if my suggestion can not be done? > >> > >> I responded with a patch, so now we can discuss both your and my suggestions. > > > > No, we can't. You responded with a patch for your suggestion, but > > not for mine. So we compare apples and oranges here. Just like > > with Ilya's patch, which only half way captured my suggestion in > > his "alternatives". > > > > In the end I'm not even sure you got it right. > > > > > > >> If I understood you correctly, you suggested to set replica self lsn to infinity > >> (on master side), so that recovery on masters side would skip replicas rows. > >> > > Does it look like I got it right from my answer? I don't understand. For example, what do you mean by setting it on the master? You were supposed to set it on the replica, when sending a SUBSCRIBE request to the master. Honestly, your English isn't perfect, we don't share the same vocabulary/terms, so it's hard to see what went wrong without a patch. -- Konstantin Osipov, Moscow, Russia https://scylladb.com