From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DBB14469719 for ; Wed, 19 Feb 2020 10:49:51 +0300 (MSK) Date: Wed, 19 Feb 2020 10:49:50 +0300 From: Kirill Yukhin Message-ID: <20200219074950.ywt4ikvhahvcc5e3@tarantool.org> References: <20191126144837.78132-1-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191126144837.78132-1-arkholga@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5] build: introduce LUAJIT_ENABLE_PAIRSMM flag List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org Hello, On 26 ноя 17:48, Olga Arkhangelskaia wrote: > Adds LUAJIT_ENABLE_PAIRSMM flag as a build option for luajit. > If the flag is set, pairs/ipairs metamethods are available in Lua 5.1. > For tarantool this option is enabled by default. > > Part of #4560 > Branch:https://github.com/tarantool/luajit/tree/OKriw/gh-4560-Enable-LUAJIT_ENABLE_LUA52COMPAT-when-bulding-luajit > > v1: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012466.html > v2: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012489.html > v3: https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012527.html This change breaks compatibility w/ Lua 5.1 and was checked into 1.10, 2.1, 2.2, 2.3 and master by mistake. Right it leads to failures in existing Lua code (see tarantool/tarantool#4770). The change was reverted in 1.10, 2.2, 2.3 and master. -- Regards, Kirill Yukhin