From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 33104469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 18 Feb 2020 22:07:09 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id x14so24239008ljd.13
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 18 Feb 2020 11:07:09 -0800 (PST)
Date: Tue, 18 Feb 2020 22:07:07 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200218190707.GC20569@atlas>
References: <cover.1582046958.git.sergepetrenko@tarantool.org>
 <ca9dc7cb741083d6f9a45c55acea942435d4daa4.1582046958.git.sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ca9dc7cb741083d6f9a45c55acea942435d4daa4.1582046958.git.sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 3/4] replication: do not relay
 rows coming from a remote instance back to it
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

* Serge Petrenko <sergepetrenko@tarantool.org> [20/02/18 20:38]:
>  	vclock_create(&replica_clock);
>  	bool anon;
> -	xrow_decode_subscribe_xc(header, NULL, &replica_uuid,
> -				 &replica_clock, &replica_version_id, &anon);
> +	bool is_orphan;
> +	xrow_decode_subscribe_xc(header, NULL, &replica_uuid, &replica_clock,
> +				 &replica_version_id, &anon, &is_orphan);


Why did you make it so complicated, could you please explain? What
went wrong with my suggestion?

-- 
Konstantin Osipov, Moscow, Russia