From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com
 [209.85.208.180])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 02CEC469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Feb 2020 20:14:17 +0300 (MSK)
Received: by mail-lj1-f180.google.com with SMTP id x7so19711246ljc.1
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Feb 2020 09:14:17 -0800 (PST)
Date: Mon, 17 Feb 2020 20:14:16 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200217171416.GB11553@atlas>
References: <20200217155953.25803-1-gorcunov@gmail.com>
 <20200217155953.25803-3-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200217155953.25803-3-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 2/4] box/journal: sanitize
	completion naming
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/02/17 20:08]:
> Instead of on_done use on_complete prefix
> since done it too general while we're trying
> to complete write procedue. Also it is more
> consistent with txn_complete name.

lgtm

-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com