From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F1DFE469719 for ; Mon, 17 Feb 2020 20:14:01 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id v201so12376669lfa.11 for ; Mon, 17 Feb 2020 09:14:01 -0800 (PST) Date: Mon, 17 Feb 2020 20:13:59 +0300 From: Konstantin Osipov Message-ID: <20200217171359.GA11553@atlas> References: <20200217155953.25803-1-gorcunov@gmail.com> <20200217155953.25803-2-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217155953.25803-2-gorcunov@gmail.com> Subject: Re: [Tarantool-patches] [PATCH 1/4] box/txn: fix void args mess List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml * Cyrill Gorcunov [20/02/17 20:08]: > Using void explicitly in functions which take > no arguments allows to optimize code a bit and > don't assume if there might be variable args. > > Moreover in commit e070cc4d9 we dropped arguments > from txn_begin but didn't update vy_scheduler.c. > The compiler didn't complain because it assumed > there are vargs. lgtm -- Konstantin Osipov, Moscow, Russia https://scylladb.com