From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EF144469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Feb 2020 13:00:21 +0300 (MSK)
Date: Mon, 17 Feb 2020 13:00:40 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200217100040.k6uzft73aqoa7djn@tkn_work_nb>
References: <1581360313.873049294@f221.i.mail.ru>
 <20200215175046.GE19902@atlas>
 <20200215201903.z6b7v33mo5ea7k4c@tkn_work_nb>
 <20200217074052.GA15384@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200217074052.GA15384@atlas>
Subject: Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did
 not work on mac
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches <tarantool-patches@dev.tarantool.org>

On Mon, Feb 17, 2020 at 10:40:52AM +0300, Konstantin Osipov wrote:
> * Alexander Turenko <alexander.turenko@tarantool.org> [20/02/15 23:22]:
> > > Is it fixed in the upstream? Why is noone complaining in the
> > > upstream? Is there a bug in the upstream?
> > 
> > Let me read changelog for you:
> 
> Well, I guess the commit comment should say that this is only an
> update from the upstream.
> 
> Let me read third_party/README for you!

Touche.

> 
> How to update libev
> ===================
> 
> Remove Tarantool patches (see csv diff -U8).
> cvs up
> Add patches back.
> 
> Did the patch follow the procedure? If it did, it should clearly
> state that it updated libev, and to which version.

Agreed, it makes sense.

> 
> 
> > 
> >  | 4.25 Fri Dec 21 07:49:20 CET 2018
> >  | <...>
> >  | - move the darwin select workaround higher in ev.c, as newer versions of
> >  |   darwin managed to break their broken select even more.
> > 
> > http://cvs.schmorp.de/libev/Changes?view=markup
> 
> :/
> 
> -- 
> Konstantin Osipov, Moscow, Russia