From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 16CC8469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Feb 2020 10:40:56 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id m30so11081692lfp.8
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 16 Feb 2020 23:40:55 -0800 (PST)
Date: Mon, 17 Feb 2020 10:40:52 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200217074052.GA15384@atlas>
References: <1581360313.873049294@f221.i.mail.ru>
 <20200215175046.GE19902@atlas>
 <20200215201903.z6b7v33mo5ea7k4c@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200215201903.z6b7v33mo5ea7k4c@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did
 not work on mac
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches <tarantool-patches@dev.tarantool.org>

* Alexander Turenko <alexander.turenko@tarantool.org> [20/02/15 23:22]:
> > Is it fixed in the upstream? Why is noone complaining in the
> > upstream? Is there a bug in the upstream?
> 
> Let me read changelog for you:

Well, I guess the commit comment should say that this is only an
update from the upstream.

Let me read third_party/README for you!

How to update libev
===================

Remove Tarantool patches (see csv diff -U8).
cvs up
Add patches back.

Did the patch follow the procedure? If it did, it should clearly
state that it updated libev, and to which version.


> 
>  | 4.25 Fri Dec 21 07:49:20 CET 2018
>  | <...>
>  | - move the darwin select workaround higher in ev.c, as newer versions of
>  |   darwin managed to break their broken select even more.
> 
> http://cvs.schmorp.de/libev/Changes?view=markup

:/

-- 
Konstantin Osipov, Moscow, Russia