From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3695F469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 15 Feb 2020 23:18:45 +0300 (MSK)
Date: Sat, 15 Feb 2020 23:19:03 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200215201903.z6b7v33mo5ea7k4c@tkn_work_nb>
References: <1581360313.873049294@f221.i.mail.ru>
 <20200215175046.GE19902@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200215175046.GE19902@atlas>
Subject: Re: [Tarantool-patches] [PATCH] libev: unlimited select flag did
 not work on mac
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Sat, Feb 15, 2020 at 08:50:46PM +0300, Konstantin Osipov wrote:
> * Maria Khaydich <maria.khaydich@tarantool.org> [20/02/10 21:45]:
> > 
> > Stress tests failed due to lack of fds for mac. The problem was in the
> > libev library where DARWIN_UNLIMITED_SELECT flag was defined too late
> > to do the trick.
> >  
> > Closes #3867, #4673

Use the following form:

 | Closes #3867
 | Closes #4673

Otherwise the latter issue will not be closed automatically when the
commit will land to master.

> Is it fixed in the upstream? Why is noone complaining in the
> upstream? Is there a bug in the upstream?

Let me read changelog for you:

 | 4.25 Fri Dec 21 07:49:20 CET 2018
 | <...>
 | - move the darwin select workaround higher in ev.c, as newer versions of
 |   darwin managed to break their broken select even more.

http://cvs.schmorp.de/libev/Changes?view=markup

WBR, Alexander Turenko.