From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com
 [209.85.167.65])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D69FA469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 15 Feb 2020 20:59:56 +0300 (MSK)
Received: by mail-lf1-f65.google.com with SMTP id v201so8936481lfa.11
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 15 Feb 2020 09:59:56 -0800 (PST)
Date: Sat, 15 Feb 2020 20:59:53 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200215175953.GC2527@uranus>
References: <20200214140339.4085-1-gorcunov@gmail.com>
 <20200214140339.4085-5-gorcunov@gmail.com>
 <20200215173851.GD19902@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200215173851.GD19902@atlas>
Subject: Re: [Tarantool-patches] [PATCH v10 4/4] test: add
 replication/applier-rollback
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Sat, Feb 15, 2020 at 08:38:51PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/02/14 17:06]:
> >  STRS(applier_state, applier_STATE);
> >  
> > @@ -832,6 +833,17 @@ applier_apply_tx(struct stailq *rows)
> >  	trigger_create(on_commit, applier_txn_commit_cb, NULL, NULL);
> >  	txn_on_commit(txn, on_commit);
> >  
> > +	/*
> > +	 * FIXME: Move this injection somewhere inside
> > +	 * txn_write, but since it has own bug (gh 4776)
> > +	 * we will cure it a bit later.
> > +	 */
> > +	ERROR_INJECT(ERRINJ_REPLICA_TXN_WRITE, {
> > +		diag_set(ClientError, ER_INJECTION,
> > +			 "replica txn write injection");
> > +		goto rollback;
> > +	});
> 
> I thought yo wrote in the changes in v10 that you pushed the error
> down into txn layer. But here you don't do it. What am I missing?

Not yet. Pushing it sown cause https://github.com/tarantool/tarantool/issues/4776
I plan to fix it and then get back to this issue. Look this
all code is still a bit vague for me, so I've to understand every
byte before doing some more deep changes. For exactly this reason
the patch in the series does NOT change the current logic of
code flow much but tries to leave everything as it were except
a hot fix for nil dereference.

That said, Kostya, I remember about your proposal and FIXME
left here for exactly that.