From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A23D469719 for ; Sat, 15 Feb 2020 00:00:07 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id r14so7646084lfm.5 for ; Fri, 14 Feb 2020 13:00:07 -0800 (PST) Date: Sat, 15 Feb 2020 00:00:05 +0300 From: Konstantin Osipov Message-ID: <20200214210005.GB12053@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v4 0/4] Safe truncation and deletion List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Ilya Kosarev [20/02/14 22:41]: > Changes in v2: > Approach changed completely: now we are not trying to allocate > service tuples in some safe way, but increasing memtx quota so > that space:truncate() and space:delete() won't fail on allocation. > > Changes in v3: > Now we are not increasing memtx quota. Instead we just set a flag to > allow quota overuse for space:truncate() and space:delete(). > > Changes in v4: > improved quota on/off flag style > took into account fail cases for box_upsert in space_truncate > now we are switching the quota off for deletion only in case there is > OutOfMemory error in diag > removed extra checks > added tests Is it intentional that first you discuss the recommendation I make on the mailing list, and then silently disregard it? -- Konstantin Osipov, Moscow, Russia