From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 57CCC469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 14 Feb 2020 17:29:21 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id e18so10908183ljn.12
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 14 Feb 2020 06:29:21 -0800 (PST)
Date: Fri, 14 Feb 2020 17:29:19 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200214142919.GB10968@atlas>
References: <20200214132220.29830-1-gorcunov@gmail.com>
 <20200214132220.29830-3-gorcunov@gmail.com>
 <20200214141704.GA10968@atlas> <20200214142220.GY21061@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200214142220.GY21061@uranus>
Subject: Re: [Tarantool-patches] [PATCH v8 2/2] fiber: leak slab if unable
 to bring prots back
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/02/14 17:22]:
> On Fri, Feb 14, 2020 at 05:17:04PM +0300, Konstantin Osipov wrote:
> > > 
> > > In future (hopefully near one) we plan to drop
> > > guard pages to prevent VMA fracturing and use
> > > stack marks instead.
> > 
> > Seriously, let's have some decency, first we pushed an optional
> > feature and then it broke and you're suggestinga hot fix that leaks 
> > memory.
> > 
> > What's the issue with disabling the broken feature?
> 
> As far as I understand we gonna drop guard pages for release
> builds only, for debug builds it will be with us, no?

Panic in debug is ok.

-- 
Konstantin Osipov, Moscow, Russia