From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A0AC3469719 for ; Fri, 14 Feb 2020 17:03:48 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id y6so10884994lji.0 for ; Fri, 14 Feb 2020 06:03:48 -0800 (PST) From: Cyrill Gorcunov Date: Fri, 14 Feb 2020 17:03:35 +0300 Message-Id: <20200214140339.4085-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v10 0/4] box/replication: add missing diag set and fix sigsegv List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml In v10 I tried to sanitize code a bit. Still there are few problems we will need (well, I'll need) to solve: - move error injection deeper into transaction code - keep former error - make sure that we really need separated replicaset diag instance (i must confess i still not follow why we need it) Anyway with the patch we stop causing nil dereference and write error log. Same time since I'll have to deal with inmemory wal task I won't leave these FIXME and continue working on them. Cyrill Gorcunov (4): box/request: add missing OutOfMemory diag_set box/applier: add missing diag_set on region_alloc failure box/applier: prevent nil dereference on applier rollback test: add replication/applier-rollback src/box/applier.cc | 43 +++++- src/box/request.c | 8 +- src/lib/core/errinj.h | 1 + test/box/errinj.result | 1 + test/replication/applier-rollback-slave.lua | 16 ++ test/replication/applier-rollback.result | 160 ++++++++++++++++++++ test/replication/applier-rollback.test.lua | 79 ++++++++++ test/replication/suite.ini | 2 +- 8 files changed, 305 insertions(+), 5 deletions(-) create mode 100644 test/replication/applier-rollback-slave.lua create mode 100644 test/replication/applier-rollback.result create mode 100644 test/replication/applier-rollback.test.lua base-commit: 95b9a48daf00b6686b8e1993a023daa0755b460e -- 2.20.1