From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com
 [209.85.167.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2FAF0469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 14 Feb 2020 10:56:53 +0300 (MSK)
Received: by mail-lf1-f68.google.com with SMTP id z26so6100198lfg.13
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 13 Feb 2020 23:56:53 -0800 (PST)
Date: Fri, 14 Feb 2020 10:56:50 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200214075650.GT21061@uranus>
References: <20200206123114.8010-1-gorcunov@gmail.com>
 <20200206123114.8010-2-gorcunov@gmail.com>
 <ae7eaa9c-7074-15a6-c91d-dafb5d1e3d0a@tarantool.org>
 <20200213081950.GM21061@uranus>
 <6e0f734a-0415-8abc-8301-759a3135da12@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6e0f734a-0415-8abc-8301-759a3135da12@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 1/2] fiber: set diagnostics at
	madvise/mprotect failure
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Fri, Feb 14, 2020 at 12:26:09AM +0100, Vladislav Shpilevoy wrote:
> >> 4. Do you need C++ here?
> > 
> > The C++ was choosen because we already have fiber_XXX.cc tests
> > so I simply tried to follow.
> > 
> >> 5. I would call it fiber_errinj.c. In future we may want to
> >> add more tests here, which use error injections. Up to you.
> > 
> > From one point of view having one big test which would cover
> > various aspects of tarantool might help discovering unexpectedly
> > connected bugs.
> 
> In case of unit tests it is rather about reducing code duplication.
> Because any fiber unit test on C includes the same headers, does
> the same preparations in main(), may need some common utilities.

I see what you mean but still prefer to have stack testings in
separate test.