From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C681A469719 for ; Fri, 14 Feb 2020 10:29:39 +0300 (MSK) Received: by mail-lf1-f52.google.com with SMTP id t23so6094146lfk.6 for ; Thu, 13 Feb 2020 23:29:39 -0800 (PST) Date: Fri, 14 Feb 2020 10:29:38 +0300 From: Konstantin Osipov Message-ID: <20200214072938.GE15237@atlas> References: <20200214071952.GA15237@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200214071952.GA15237@atlas> Subject: Re: [Tarantool-patches] [PATCH v2 2/4] replication: check for rows to skip in applier correctly List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergepetrenko , alexander.turenko@tarantool.org, v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org * Konstantin Osipov [20/02/14 10:19]: > I think you should patch SUBSCRIBE iproto command, not the filter > itself. > > Basically, if it's *re*configuraiton, not first replication > configuration, SUBSCRIBE should set local VCLOCK component to > infinity (check out variable local_vclock_at_subscribe, how it is > assigned and how it used by the relay). should be: check replica_vclock, how it's assigned and how it's used by the relay. What I mean is: Set replica_vclock[self] = infinity before sending at resubscribe. then you don't need any filters. -- Konstantin Osipov, Moscow, Russia https://scylladb.com