From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C8906469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 14 Feb 2020 10:26:19 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id y6so9585266lji.0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 13 Feb 2020 23:26:19 -0800 (PST)
Date: Fri, 14 Feb 2020 10:26:18 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200214072618.GD15237@atlas>
References: <cover.1581551227.git.sergepetrenko@tarantool.org>
 <05d98ad17bd55b1437511c7ed57ee82a9a1625f9.1581551227.git.sergepetrenko@tarantool.org>
 <20200213064831.GB17713@atlas>
 <1581631549.621693072@f191.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1581631549.621693072@f191.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write
 a record with a broken lsn
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

* Sergey Petrenko <sergepetrenko@tarantool.org> [20/02/14 09:46]:
> 
> 
> 
> >Четверг, 13 февраля 2020, 9:48 +03:00 от Konstantin Osipov <kostja.osipov@gmail.com>:
> >
> >* sergepetrenko < sergepetrenko@tarantool.org > [20/02/13 09:34]:
> >> There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't
> >> fire in release builds, of course. So we better panic on an attemt to
> >> write a record with a duplicate or otherwise broken lsn.
> >> 
> >
> >It should be a warning in production. You can't crash production
> >deploy because of a server bug, and lsn inconsistency is always a
> >server bug.
> Well, this inconsistency yields a WAL that cannot be recovered from.
> But I don't have a strong opinion here. I changed it to a warning in v2.

It can, with force_recovery. Besides, you can make a snapshot.


-- 
Konstantin Osipov, Moscow, Russia
https://scylladb.com