From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 88AFA469719 for ; Fri, 14 Feb 2020 10:20:23 +0300 (MSK) Received: by mail-lj1-f178.google.com with SMTP id e18so9501752ljn.12 for ; Thu, 13 Feb 2020 23:20:23 -0800 (PST) Date: Fri, 14 Feb 2020 10:20:21 +0300 From: Konstantin Osipov Message-ID: <20200214072021.GB15237@atlas> References: <97f37279955ebc29e899164cc1364e6a0aea0f9b.1581630406.git.sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <97f37279955ebc29e899164cc1364e6a0aea0f9b.1581630406.git.sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergepetrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * sergepetrenko [20/02/14 09:46]: > From: Serge Petrenko > > There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't > fire in release builds, of course. Let's at least warn the user on an > attemt to write a record with a duplicate or otherwise broken lsn. wart is бородавка. I think you meant warn :) otherwise lgtm -- Konstantin Osipov, Moscow, Russia https://scylladb.com