From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7249A469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 13 Feb 2020 11:20:42 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id x7so5539993ljc.1
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 13 Feb 2020 00:20:42 -0800 (PST)
Date: Thu, 13 Feb 2020 11:20:39 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200213082039.GN21061@uranus>
References: <20200206123114.8010-1-gorcunov@gmail.com>
 <20200206123114.8010-3-gorcunov@gmail.com>
 <90607bfb-8f31-765f-ae8d-7cdb34598b0c@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <90607bfb-8f31-765f-ae8d-7cdb34598b0c@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/2] fiber: leak slab if unable
 to bring prots back
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Feb 13, 2020 at 01:08:45AM +0100, Vladislav Shpilevoy wrote:
> > -			diag_log();
> > +			say_syserror("fiber: Can't put guard page to slab. "
> > +				     "Leak %zu bytes", (size_t)fiber->stack_size);
> 
> This behaviour actually should be testable, no? You could not test
> diag, but you should be able to detect a leak. Using slab_cache_used(),
> for example. Before and after a test.

Will try, thanks!