From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 33D88469719 for ; Thu, 13 Feb 2020 09:48:33 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id e18so5236035ljn.12 for ; Wed, 12 Feb 2020 22:48:33 -0800 (PST) Date: Thu, 13 Feb 2020 09:48:31 +0300 From: Konstantin Osipov Message-ID: <20200213064831.GB17713@atlas> References: <05d98ad17bd55b1437511c7ed57ee82a9a1625f9.1581551227.git.sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05d98ad17bd55b1437511c7ed57ee82a9a1625f9.1581551227.git.sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/2] wal: panic when trying to write a record with a broken lsn List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergepetrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * sergepetrenko [20/02/13 09:34]: > There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't > fire in release builds, of course. So we better panic on an attemt to > write a record with a duplicate or otherwise broken lsn. > It should be a warning in production. You can't crash production deploy because of a server bug, and lsn inconsistency is always a server bug. -- Konstantin Osipov, Moscow, Russia