From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6B656469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 12 Feb 2020 17:10:44 +0300 (MSK)
Date: Wed, 12 Feb 2020 17:10:42 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200212141042.GD8095@tarantool.org>
References: <cover.1580841722.git.korablev@tarantool.org>
 <8e0dd524221265bfba1906e1bc6fb0608b1f0c45.1580841722.git.korablev@tarantool.org>
 <eee149e2-52be-6179-0f59-34c2beaac9a9@tarantool.org>
 <20200211141432.GA5708@tarantool.org>
 <7af1a58c-c315-7656-5930-ab1f33e19bfa@tarantool.org>
 <20200211232015.GC8095@tarantool.org>
 <ff636f21-aa9e-4486-4ad8-aab63e01c578@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ff636f21-aa9e-4486-4ad8-aab63e01c578@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 12 Feb 00:27, Vladislav Shpilevoy wrote:
> On 12/02/2020 00:20, Nikita Pettik wrote:
> > On 11 Feb 23:17, Vladislav Shpilevoy wrote:
> >> Hi!
> >>
> >> I've pushed my review fixes on top of this commit. See it in the
> >> end of the email, and on the branch.
> >>
> >> 3.2 and 3.13 still were the same, I dropped 3.13.
> > 
> > Don't bother with such insignificant things, I am always ok with these fixes.
> > Just amend them and force push already squashed :)
> 
> Ok, will take that into account next time
> 
> > Ofc I've applied your fixes, thanks.
> 
> The patchset LGTM then.

Pushed to master only. Milestone for this issue is 2.2.3, but 2.2 lacks
DOUBLE type, so patches can't be applied.

I did not push to 2.3 since I don't consider this issue to be a bug,
but rather behaviour change in type system. However, if somebody
insists on adding this change to 2.3 then I won't mind.