From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1ABAF469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 12 Feb 2020 02:20:16 +0300 (MSK)
Date: Wed, 12 Feb 2020 02:20:15 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200211232015.GC8095@tarantool.org>
References: <cover.1580841722.git.korablev@tarantool.org>
 <8e0dd524221265bfba1906e1bc6fb0608b1f0c45.1580841722.git.korablev@tarantool.org>
 <eee149e2-52be-6179-0f59-34c2beaac9a9@tarantool.org>
 <20200211141432.GA5708@tarantool.org>
 <7af1a58c-c315-7656-5930-ab1f33e19bfa@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <7af1a58c-c315-7656-5930-ab1f33e19bfa@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 11 Feb 23:17, Vladislav Shpilevoy wrote:
> Hi!
> 
> I've pushed my review fixes on top of this commit. See it in the
> end of the email, and on the branch.
> 
> 3.2 and 3.13 still were the same, I dropped 3.13.

Don't bother with such insignificant things, I am always ok with these fixes.
Just amend them and force push already squashed :)

Ofc I've applied your fixes, thanks.

> ================================================================================
> 
> commit 6f1ce3265cab561c7d4959bd1a1998a986287da7
> Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Date:   Tue Feb 11 23:14:48 2020 +0100
> 
>     Review fix
> 
> diff --git a/test/sql-tap/cast.test.lua b/test/sql-tap/cast.test.lua
> index d4af339fd..fb0790d04 100755
> --- a/test/sql-tap/cast.test.lua
> +++ b/test/sql-tap/cast.test.lua
> @@ -1,6 +1,6 @@
>  #!/usr/bin/env tarantool
>  test = require("sqltester")
> -test:plan(80)
> +test:plan(79)
>  
>  --!./tcltestrunner.lua
>  -- 2005 June 25
> @@ -682,11 +682,6 @@ test:do_execsql_test(
>          -- </cast-3.12>
>      })
>  
> -test:do_execsql_test(
> -    "cast-3.13",
> -    "SELECT CAST(9223372036854774800 AS NUMBER)",
> -    {9223372036854774800LL})
> -
>  test:do_execsql_test(
>      "cast-3.14",
>      [[