From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B298D46970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  6 Feb 2020 20:59:06 +0300 (MSK)
Date: Thu, 6 Feb 2020 20:59:05 +0300
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200206175905.GC27490@tarantool.org>
References: <20200127140420.52553-1-k.sosnin@tarantool.org>
 <00aac4ac-e194-7c45-6cfd-7f288799d262@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <00aac4ac-e194-7c45-6cfd-7f288799d262@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: fix segfault in pragma
 table_info
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 05 Feb 23:22, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch! LGTM.

Pushed to master, 2.3 and 2.2
 
> On 27/01/2020 15:04, Chris Sosnin wrote:
> > We should first check that primary key is not NULL.
> > 
> > Closes #4745
> > ---
> > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4745-table-info-assertion
> > issue: https://github.com/tarantool/tarantool/issues/4745