From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B98EB46970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  6 Feb 2020 14:20:14 +0300 (MSK)
Date: Thu, 6 Feb 2020 14:20:28 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200206112028.tonvbqhiqi2oppcl@tkn_work_nb>
References: <20200205220624.8764-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200205220624.8764-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v5 0/2] fiber: Handle stack
	madvise/mprotect errors
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

LGTM (except several minor points; fixes for them are obvious and it is
not necessary to re-review the patchset with me).

Please, fix those points and send the patch to Vlad for the second
review.

WBR, Alexander Turenko.

On Thu, Feb 06, 2020 at 01:06:22AM +0300, Cyrill Gorcunov wrote:
> issue https://github.com/tarantool/tarantool/issues/4722
> branch gorcunov/gh-4722-mprotect-diag-error-5
> 
> In v5:
>  - merged errinj together with test into the patch itself
>  - on guard page restore we print error and continue instead
>    of immeadiate exit
> 
> Cyrill Gorcunov (2):
>   fiber: use diag_ logger in fiber_madvise/mprotect failures
>   fiber: leak slab if unable to bring prots back
> 
>  src/lib/core/errinj.h        |    2 +
>  src/lib/core/fiber.c         |   92 +-
>  test/box/errinj.result       | 2616 ++++++++++++++++++----------------
>  test/unit/CMakeLists.txt     |    4 +
>  test/unit/fiber_stack.cc     |   83 ++
>  test/unit/fiber_stack.result |    6 +
>  test/unit/suite.ini          |    2 +-
>  7 files changed, 1530 insertions(+), 1275 deletions(-)
>  create mode 100644 test/unit/fiber_stack.cc
>  create mode 100644 test/unit/fiber_stack.result
> 
> -- 
> 2.20.1
>